Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

fix class-b RFC1918 network #2908

Merged
merged 4 commits into from
Jul 5, 2024
Merged

fix class-b RFC1918 network #2908

merged 4 commits into from
Jul 5, 2024

Conversation

ctr49
Copy link
Contributor

@ctr49 ctr49 commented Jun 28, 2024

I'm pretty sure this should be 192.168.0.0/16, not 192.128.0.0/16 as per RFC1918. Nothing against AT&T (who own 192.128.0.0/16)...

ctr49 added 2 commits June 28, 2024 19:16
I'm pretty sure this should be 192.168.0.0/16, not 192.128.0.0/16 as per RFC1918. Nothing against AT&T (who own 192.128.0.0/16)...
@sandhose
Copy link
Member

sandhose commented Jul 1, 2024

Good catch! Indeed, nothing against AT&T :)

This file is generated though, so you'd need to update the IP here:

IpNetwork::new([192, 128, 0, 0].into(), 16).unwrap(),

And then run sh misc/update.sh (or just cargo run -p mas-config > ./docs/config.schema.json if you don't have a full dev environment working. This only requires cargo/rust to be installed)

@sandhose sandhose enabled auto-merge (rebase) July 5, 2024 08:14
@sandhose sandhose disabled auto-merge July 5, 2024 08:14
@sandhose sandhose enabled auto-merge (squash) July 5, 2024 08:15
@sandhose sandhose merged commit 3ab733b into matrix-org:main Jul 5, 2024
15 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants