This repository has been archived by the owner on Sep 10, 2024. It is now read-only.
Remove OPA-based password policy enforcement #2875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
8241059
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22cf3487.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://rei-rm-password-policy-eng.matrix-authentication-service-docs.pages.dev |
reivilibre
force-pushed
the
rei/rm_password_policy_eng
branch
from
27fd30e to
c3a782c
Compare
reivilibre
force-pushed
the
rei/rm_password_policy_eng
branch
from
c3a782c to
8efde0e
Compare
reivilibre
force-pushed
the
rei/rm_password_policy_eng
branch
from
8efde0e to
9779a21
Compare
sandhose
suggested changes
Jul 8, 2024
There was a problem hiding this comment.
Could you also remove it from the policy itself?
That would be:
- the
policy/password.regoandpolicy/password_test.regofiles - references to policy in the registration policy: here and here
- remove reference in the
policy/Makefilelike here - remove the
passwordin the registration input here (and regenerate the OPA input schema, which should be handled bymisc/update.sh)
reivilibre
force-pushed
the
rei/rm_password_policy_eng
branch
2 times, most recently
from
911f6b2 to
10e58ce
Compare
reivilibre
force-pushed
the
rei/rm_password_policy_eng
branch
from
10e58ce to
82a2674
Compare
sandhose
approved these changes
Jul 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OPA-based policies are too opaque and complicated; this is a precursor to just using the zxcvbn algorithm, which should let us provide better feedback in real-time to the users. (#172)