Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve package version fetching reliability #437

Merged
merged 4 commits into from
Sep 15, 2022
Merged

Improve package version fetching reliability #437

merged 4 commits into from
Sep 15, 2022

Conversation

Half-Shot
Copy link
Contributor

Fixes #436

This code now looks for the package.json adjacent to the main module script, and iterates backwards. This is only done once on first fetch, so should be fairly performant.

@Half-Shot Half-Shot requested a review from a team as a code owner September 13, 2022 09:15
justinbot
justinbot approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@justinbot justinbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions but otherwise looks good

src/utils/package-info.ts Show resolved Hide resolved
src/utils/package-info.ts Show resolved Hide resolved
@Half-Shot Half-Shot enabled auto-merge (squash) September 15, 2022 17:06
@Half-Shot Half-Shot merged commit 76438ff into develop Sep 15, 2022
@Half-Shot Half-Shot deleted the hs/improve-package-version branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinbot justinbot justinbot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getBridgeVersion isn't reliable
2 participants
@Half-Shot @justinbot