Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signoff script #428

Merged
merged 11 commits into from
Jul 27, 2022
Merged

Add signoff script #428

merged 11 commits into from
Jul 27, 2022

Conversation

Half-Shot
Copy link
Contributor

This does a simple check to ensure that the PR contains a sign off if the contributor isn't a member of the matrix-org project.

@Half-Shot Half-Shot requested a review from a team as a code owner July 26, 2022 23:29
tadzik
tadzik approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@tadzik tadzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Is that some standard script, maybe something we can share between repos?

@Half-Shot
Copy link
Contributor Author

I'm hoping we can do a simple import between repos.

@Half-Shot Half-Shot merged commit ddfbbf7 into develop Jul 27, 2022
@Half-Shot Half-Shot mentioned this pull request Jul 27, 2022
Merged
@Half-Shot Half-Shot deleted the hs/signoff-script branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadzik tadzik tadzik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @tadzik