Logging system refactor #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(in case it was missed: the bot-sdk has a |
Yep, the current problem is that it lacks the ability to set freeform metadata on the Logging object which is something we're going to end up needing for the Request logging we have planned. Given the time-to-merge delays on matrix-bot-sdk, it's not something we're going to be able to depend on easily, hence running out own solution. We still wrap the bot-sdk logger so that the logs get piped nicely into one place. |
Half-Shot
force-pushed
the
hs/logging-refactor
branch
from
d6c2c8d to
44d389f
Compare
Half-Shot
force-pushed
the
hs/logging-refactor
branch
from
d097509 to
7da88b8
Compare
jaller94
reviewed
Sep 21, 2022
jaller94
reviewed
Sep 21, 2022
jaller94
reviewed
Sep 21, 2022
jaller94
reviewed
Sep 21, 2022
jaller94
suggested changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split out from #410
Our current logging system is hard to use, and also difficult to override. As such we've ended up building our own solutions in the Discord bridges, IRC bridge and the hookshot bridge. This PR attempts to pull in the hookshot way of doing logging into this bridge without trying to break the API entirely.
I've retained our existing log rotation transport feature, but I'm not wholly convinced it's something we want long term. Log rotation is best left to other services (KISS principle applies).
For reference https://github.com/matrix-org/matrix-hookshot/blob/main/src/LogWrapper.ts
The PR rotted enough that trying to merge some changes in broke the world, so I have restarted again on a single PR.