Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate edit events come from the same user #329

Merged
merged 11 commits into from
Jun 3, 2021
Merged

Validate edit events come from the same user #329

merged 11 commits into from
Jun 3, 2021

Conversation

Half-Shot
Copy link
Contributor

To avoid a user being able to fake an edited event

@MadLittleMods MadLittleMods self-requested a review June 2, 2021 17:00
MadLittleMods
MadLittleMods approved these changes Jun 2, 2021
View reviewed changes
Copy link
Contributor

@MadLittleMods MadLittleMods left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I went over the changes again and everything looks good. We also have tests for the happy paths and rejection paths ✅

@Half-Shot Half-Shot merged commit 30f6284 into develop Jun 3, 2021
@Half-Shot Half-Shot deleted the eric+hs/edit-validation branch May 2, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadLittleMods MadLittleMods MadLittleMods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Half-Shot @MadLittleMods