Add Intent.ensureProfile #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaller94
reviewed
Mar 24, 2021
| * @param displayname The displayname to set. Leave undefined to ignore. | ||
| * @param avatarUrl The avatar to set. Leave undefined to ignore. | ||
| */ | ||
| public async ensureProfile(displayname?: string, avatarUrl?: string) { |
There was a problem hiding this comment.
Might be a bit too much of an edge case:
How to ensure the display name or avatarUrl is unset?
Falsy values will get ignored or cause the function to throw.
There was a problem hiding this comment.
Hmm, good question. In fairness the spec doesn't actually give you a way to unset a profile https://spec.matrix.org/unstable/client-server-api/#profiles so it's always been a bit troublesome. I'd probably say for now that the bridge should explicitly unset a profile key if they want to remove it rather than calling this function.
It's also fairly edge-casey
jaller94
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick helper function which bridges can call on the bot after startup to check the correct profile info is set.