Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hook into the matrix-js-sdk logger and output through winston #280

Merged
merged 5 commits into from
Nov 20, 2020

Conversation

Half-Shot
Copy link
Contributor

This fixes a longstanding bug where the js-sdk would log directly to the console which would cause spam in stdout. To solve this, we now log to winston.

@Half-Shot Half-Shot requested a review from a team November 19, 2020 19:30
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/components/client-factory.ts Outdated Show resolved Hide resolved
src/components/client-factory.ts Outdated Show resolved Hide resolved
Copy link
Member

@benparsons benparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Half-Shot Half-Shot merged commit 1f701e0 into develop Nov 20, 2020
@Half-Shot Half-Shot deleted the hs/js-sdk-log branch May 2, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants