Don't join on kicking yourself #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Half-Shot
force-pushed
the
hs/dont-join-on-kick
branch
from
209d759 to
6efe4ad
Compare
Half-Shot
requested review from
a team and
benparsons
and removed request for
a team
jaywink
approved these changes
Oct 13, 2020
The resulting state is identical, so matrix client's wont know any difference. It's just a bit yuck from a "we're calling kick to do a leave" perspective. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've also taken the liberty to add a
userIdgetter to the class, as we use it all over the place. I've also added support for folks to leave with a reason. Eventually we could use the leave call, but the JS SDK doesn't let us use a reason. You can leave with a reason in the matrix spec, so it's fine to send a kick instead for now.