Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated media requests don't seem to work at all? #3420

Closed
Lunaphied opened this issue Sep 11, 2024 · 7 comments
Closed

Authenticated media requests don't seem to work at all? #3420

Lunaphied opened this issue Sep 11, 2024 · 7 comments

Comments

@Lunaphied
Copy link

Background information

  • Dendrite version or git SHA: 0.13.7
  • SQLite3 or Postgres?: Postgres
  • Running in Docker?: No
  • go version: Irrelevant/unknown (using as packaged from Nixpkgs)
  • Client used (if applicable): Cinny/Element

Description

  • What is the problem: Media requests to servers that only support authenticated media requests (like matrix.org itself) always 404
  • Who is affected: Everyone using Dendrite
  • How is this bug manifesting: Log messages about failed media requests
  • When did this first appear: Recently, likely when matrix.org disabled unauthenticated fetch

Steps to reproduce

  • Start an encrypted DM with someone from Matrix.org
  • Have them send an image
  • Observe error
Sep 10 18:08:41 homura dendrite[14339]: time="2024-09-11T00:08:41.576265018Z" level=error msg="r.fetchRemoteFileAndStoreMetadata: failed to fetch remote file" MediaID=redacted Origin=matrix.org error="File with media ID \"redacted\" does not exist on matrix.org" req.id=KiQCE521bkpb req.method=GET req.path=/_matrix/media/v3/download/matrix.org/redacted

all redacteds are the same ID.

@viviicat
Copy link

Looking at the history, this might be because they have not made a release with that functionality yet? I believe it was added in August in #3397

Tomorrow I'm going to try with a more recent build to see if that resolves it.

@viviicat
Copy link

Yeah, running from a main build resolved my issue.

@S7evinK
Copy link
Contributor

S7evinK commented Sep 11, 2024

Also keep in mind that you need a client that supports authed media through the unstable feature announced in /versions, as we do not have support for Matrix v1.11 yet.

@McSinyx
Copy link

McSinyx commented Sep 11, 2024

What clients would work then?

@S7evinK
Copy link
Contributor

S7evinK commented Sep 11, 2024

AFAIK, FluffyChat and nheko either use the unstable feature, or just try the new endpoints and use them.

@Lunaphied
Copy link
Author

Looking at the history, this might be because they have not made a release with that functionality yet? I believe it was added in August in #3397

Ah looks like my quick peruse and search of the sources and PRs missed this, thank you! Manually bumping my package to use the latest sources seems to address the issue so the solution for this should be as simple as cutting a new release of dendrite

@S7evinK
Copy link
Contributor

S7evinK commented Sep 22, 2024

#3431 was merged, so hopefully some/all of this was fixed, if not, feel free to re-open.

@S7evinK S7evinK closed this as completed Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants