Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two key-upload-related tests being blacklisted by synapse #517

Open
ShadowJonathan opened this issue Oct 16, 2022 · 0 comments
Open

Two key-upload-related tests being blacklisted by synapse #517

ShadowJonathan opened this issue Oct 16, 2022 · 0 comments

Comments

@ShadowJonathan
Copy link
Contributor

When I was looking over SkipIfs in the codebase, I found out that these following tests are explicitly blacklisted on synapse.

t.Run("Should reject keys claiming to belong to a different user", func(t *testing.T) {

t.Run("Rejects invalid device keys", func(t *testing.T) {

Seeing as how these tests are related to data validation on a server's side, I do not understand why Synapse wants to skip them, thus this issue as a nag; Why does Synapse skip these tests?

I want to update the comment with a reason given, or a reference to an issue/discussion about exactly that, or to an issue working towards clearing this skip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant