Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disambiguate blueprints by hash instead of name #273

Open
ShadowJonathan opened this issue Dec 10, 2021 · 1 comment
Open

Disambiguate blueprints by hash instead of name #273

ShadowJonathan opened this issue Dec 10, 2021 · 1 comment

Comments

@ShadowJonathan
Copy link
Contributor

This was one thing that tripped me up, while making a custom blueprint, initially the tests weren't properly working, I soon discovered this was because of the fact that blueprints are disambiguated by name.

It's a bit of a foot gun in my opinion, so I'm proposing that the implementation instead hashes these blueprint contents, and then generates them via their hashes, so that any duplicate deployment is deduplicated by their eventual instructions and contents, instead of the name.

I'm using "hash" loosely here, but "an identifier depending on the contents" would work as well.

@ShadowJonathan
Copy link
Contributor Author

I had a look at the way complement constructs blueprints, and there may be a side-effect due to the absence of this; If a blueprint is edited, the changes will not immediately propagate, due to the fact it caches on the name, not the contents of the blueprint.

In other words, if someone alters a blueprint while testing, they will get bugs due to complement still using the old image, only a docker system prune will remove that named image from the cache.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant