From 0c5c0a756ea986c6486438af0d72c842f8d4e802 Mon Sep 17 00:00:00 2001 From: Will Hunt Date: Mon, 1 Aug 2022 10:45:18 +0100 Subject: [PATCH] sign-off: Fix link and add format advice (#11) As found in https://github.com/matrix-org/matrix-hookshot/pull/430, the linkifying in GitHub included the `.` and so the anchor didn't work. Also, it turns out people sometimes miss the format we expect and do their own thing. Rather than trying to make the regex even more lenient, I'd rather just suggest the format we expect explicitly. --- .github/workflows/sign-off.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/sign-off.yml b/.github/workflows/sign-off.yml index 2c3228f..b51040f 100644 --- a/.github/workflows/sign-off.yml +++ b/.github/workflows/sign-off.yml @@ -46,5 +46,6 @@ jobs: return; } - core.setFailed('No sign off found. Please ensure you have signed off following the advice in https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off.') + core.setFailed('No sign off found. Please ensure you have signed off following the advice in https://matrix-org.github.io/synapse/latest/development/contributing_guide.html#sign-off .') + core.notice('Ensure you have matched the format `Signed-off-by: Your Name `') core.notice('If you have signed off privately instead (following the steps in Private Sign off), you can ignore this test.')