-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove jupyterlab==3.* requirement so as to allow 4.x to work. #539
Comments
The requires you are pointing to are the build requirements, these should only be needed if you build from source. ipympl has no runtime dependency on jupyterlab so it should be installable whilst checking dependencies versions. Are you trying to install it from source? We should definitely update ipympl to build against JupyterLab 4 at some point, but we are lacking maintainers. Any PR attempt would be greatly appreciated! |
I'd be happy to write one. Is the intention to support either 3 or 4 (since 4 seems to work) but limit it to not build against a hypothetical 5? Or is the >=3.0.0 dropping ==3.* acceptable? |
We can build against one JupyterLab version at a time, as of today we build ipympl using JupyterLab 3, but again this does not mean that ipympl doesn't work with JupyterLab 4, it does work (with probably a simple harmless warning in the JavaScript console at runtime). If we start building against JupyterLab 4, this should not break JupyterLab 3 support. |
This is basically a duplicate of #532 but I don't think the original intent was understood (and I can't reopen that one as I'm not affiliated). It appears ipympl works with jupyterlab if you install it without checking deps (which can be extremely frustrating for certain tools). In pyproject.toml you have:
requires = ["jupyter_packaging~=0.7.0", "jupyterlab>=3.0.0,==3.*", "setuptools>=40.8.0", "wheel"]
Changing this to:
requires = ["jupyter_packaging~=0.7.0", "jupyterlab>=3.0.0", "setuptools>=40.8.0", "wheel"]
Would be greatly appreciated!
The text was updated successfully, but these errors were encountered: