Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell has no way to remove/unset an env var #100

Open
RalfJung opened this issue Jan 11, 2025 · 4 comments
Open

Shell has no way to remove/unset an env var #100

RalfJung opened this issue Jan 11, 2025 · 4 comments

Comments

@RalfJung
Copy link

I went over the API list three times as I was sure I must just be missing this function, but I can't find it -- it seems like there is no way to remove an env var via Shell? That seems like an odd gap in functionality -- is there any particular reason for this or would a PR adding the missing method be accepted?

@RalfJung
Copy link
Author

RalfJung commented Jan 11, 2025

I'm pretty sure that implementation is subtly wrong (it un-does a previous Shell::set_var but does remove the env var if it is set in the OS env var list)... so completely on-brand for an AI bot :/

@RalfJung
Copy link
Author

@matklad did you ask for this bot to post here? If not IMO we should report it.

@lnicola
Copy link
Collaborator

lnicola commented Jan 11, 2025

screw those closing braces

Latta AI, probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@lnicola @RalfJung and others