Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parking_lot implementation tests fail under Miri due to compare_exchange_weak failures #186

Closed
saethlin opened this issue Jul 2, 2022 · 3 comments · Fixed by #187
Closed

Comments

@saethlin
Copy link
Contributor

saethlin commented Jul 2, 2022

compare_exchange_weak is allowed to spuriously fail. By default, Miri makes most calls fail so this panics when running tests:

Err(_) => debug_assert!(false),

@RalfJung
Copy link
Contributor

RalfJung commented Jul 2, 2022

Looks like this code simply wants compare_exchange without the "weak", if it does not want to handle spurious failures?

@matklad
Copy link
Owner

matklad commented Jul 2, 2022

Nah, that’s just a bug, it should have Err(INCOMPLETE) => (), branch

@matklad
Copy link
Owner

matklad commented Jul 4, 2022

@RalfJung in case no-one has told you this yet, miri is very cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants