Skip to content

fix: use bor_getAuthor instead of block.miner to fetch block miner#151

Merged
marcello33 merged 1 commit into
masterfrom
raneet10/fix-eip1559-test
Feb 8, 2023
Merged

fix: use bor_getAuthor instead of block.miner to fetch block miner#151
marcello33 merged 1 commit into
masterfrom
raneet10/fix-eip1559-test

Conversation

@Raneet10
Copy link
Copy Markdown
Contributor

@Raneet10 Raneet10 commented Feb 8, 2023

Description

Earlier when fetching a block via getBlock returned the block producer address instead of 0x00... in the block.miner field. This change was reverted in 0xPolygon/bor#631 . This led to breaking some assertions in EIP-1559 test script. This PR fixes that.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants