Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutting kernel and jupyterlab doesn't kill MATLAB or proxy process #55

Closed
asfilion opened this issue Aug 18, 2023 · 3 comments
Closed
Assignees

Comments

@asfilion
Copy link

I can use the proxy with R2023a and Python 3.10 on Windows 11. When I shut down the MATLAB kernel and shut down jupyterlab, the MATLAB process and matlab-proxy-app.exe process are still active. If I reopen jupyterlab and use the proxy again, I'll get another MATLAB and proxy process. I don't see any way to shut these processes other than manually killing them in the task manager.

@prabhakk-mw
Copy link
Member

Thank you @asfilion, I've been able to reproduce this issue and we are working towards a fix.

@rashedmyt
Copy link
Member

Hi @asfilion

MATLAB Integration for Jupyter currently uses jupyter-server-proxy to provide both MATLAB in browser and MATLAB Kernel functionalities. Unfortunately, jupyter-server-proxy doesn't plug-in to the shutdown infrastructure provided by jupyter.

However, if you have access to the terminal from which JupyterLab is launched, you can use CTRL+C to shutdown both JupyterLab and MATLAB Integration.

There is a pending PR on jupyter-server-proxy repository which provides more access to manage the integration. For more information, please look at jupyterhub/jupyter-server-proxy#395

Hope this helps.

@krisctl
Copy link
Member

krisctl commented Jan 24, 2025

This restriction has been now lifted and one can now shutdown matlab-proxy and corresponding MATLAB via the MATLAB Kernel shutdown* and JupyterLab Shut Down from the JupyterLab interface. Please see the attached video for demo purposes.

* When multiple MATLAB Kernels are accessing the same backend matlab-proxy, termination of matlab-proxy is delayed until the last reference to the backend matlab-proxy is not cleaned up

JMP.55.mp4

@krisctl krisctl added the demo label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants