From 33c7cd593503192283c30288154b745bbd47807f Mon Sep 17 00:00:00 2001 From: Peter Lynch Date: Sat, 17 Apr 2021 16:44:42 -0300 Subject: [PATCH 1/2] Remove Jenkinsfile from default excludes Jenkinsfile is intended to be checked into SCM. As such it should contain a license just like any other source file. https://www.jenkins.io/doc/book/pipeline/jenkinsfile/ --- .../src/main/java/com/mycila/maven/plugin/license/Default.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/Default.java b/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/Default.java index f57ac7749..d3a621640 100755 --- a/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/Default.java +++ b/license-maven-plugin/src/main/java/com/mycila/maven/plugin/license/Default.java @@ -198,9 +198,6 @@ public final class Default { "**/*.ods", "**/*.pdf", - // Jenkins - "**/Jenkinsfile", - // Travis "**/.travis.yml", From d70e711e4071d6a47afb53f0bb9b1f0e6cdb4e26 Mon Sep 17 00:00:00 2001 From: Peter Lynch Date: Sat, 17 Apr 2021 17:14:01 -0300 Subject: [PATCH 2/2] Add test --- .../maven/plugin/license/DefaultTest.java | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) create mode 100644 license-maven-plugin/src/test/java/com/mycila/maven/plugin/license/DefaultTest.java diff --git a/license-maven-plugin/src/test/java/com/mycila/maven/plugin/license/DefaultTest.java b/license-maven-plugin/src/test/java/com/mycila/maven/plugin/license/DefaultTest.java new file mode 100644 index 000000000..481d9da70 --- /dev/null +++ b/license-maven-plugin/src/test/java/com/mycila/maven/plugin/license/DefaultTest.java @@ -0,0 +1,18 @@ +package com.mycila.maven.plugin.license; + +import java.util.Arrays; + +import org.hamcrest.CoreMatchers; +import org.junit.Test; + +import static org.hamcrest.CoreMatchers.containsString; +import static org.hamcrest.CoreMatchers.not; +import static org.hamcrest.MatcherAssert.assertThat; + +public class DefaultTest +{ + @Test + public void test_Jenkinsfile_is_not_a_default_exclude() { + assertThat(Arrays.asList(Default.EXCLUDES), not(CoreMatchers.hasItems(containsString("Jenkinsfile")))); + } +}