Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The prepublish script changes the export signature, mismatch to @types/punycode #112

Open
retorquere opened this issue Oct 13, 2020 · 1 comment
Open

The prepublish script changes the export signature, mismatch to @types/punycode #112

retorquere opened this issue Oct 13, 2020 · 1 comment

Comments

@retorquere
Copy link

The prepublish script changes the export signature, and in the npm-published package this new export signature makes it mismatch the type declaration in @types/punycode for typescript.
@doggy8088
Copy link

doggy8088 commented Jul 9, 2021 •
edited
Loading

I think the @types/punycode is for Node.js' built-in and deprecated punycode module. This will be deprecated since v7.0.0. (coming soon)

I'd like to suggest @bestiejs or @mathiasbynens include it's own TypeScript Declaration File within this package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@doggy8088 @retorquere