Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to fully configure exploration summarization #3875

Closed
seancolsen opened this issue Sep 24, 2024 · 2 comments
Closed

Unable to fully configure exploration summarization #3875

seancolsen opened this issue Sep 24, 2024 · 2 comments
Assignees
Labels
ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Sep 24, 2024

Summarization transforms are broken in a weird way. Adding a summarization transformation hides all but the selected column. And the UI to configure the aggregation is missing.

master branch explorations branch
image image
@seancolsen seancolsen added ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue type: bug work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory labels Sep 24, 2024
@seancolsen seancolsen added this to the v0.2.0-testing.1 milestone Sep 24, 2024
@seancolsen
Copy link
Contributor Author

seancolsen commented Sep 25, 2024

@Anish9901 I've spent some more time troubleshooting this, and I think it's likely a backend bug. So I'd like you to look into it next to see if you can identify a fix.

Here are my reproduction steps.

  1. Run off my explorations branch and off master (e.g. via our internal site) for comparison.

  2. Begin an exploration using the Authors table in our library data.

  3. Add the First Name column and the id column (in that order).

  4. Add a summarization transformation.

  5. Observe that the API requests are essential identical across the two versions (except for some minor differences due to RPC migration and attnums/oids).

  6. Observe that the API responses differ in two important ways:

    • Return records have missing columns. (Compare the entries in records.results.)

    • Returned output columns list is missing columns.

      In master, output_columns is:

      [
        "Authors_First Name_grouped",
        "Authors_id_agged"
      ]

      In explorations, output_columns is:

      [
        "Authors_First Name_grouped"
      ]

      I think the missing UI may be due to there only being a single entry in the returned output_columns array.

@seancolsen seancolsen removed the work: frontend Related to frontend code in the mathesar_ui directory label Sep 25, 2024
@Anish9901 Anish9901 mentioned this issue Sep 26, 2024
7 tasks
@seancolsen
Copy link
Contributor Author

#3884 seems to fix the backend problems described in this issue, so I'm allowing that PR to close this issue when it's merged.

However during my testing I identified that there still appears to be a front end issue here. I've opened #3887 to track that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

No branches or pull requests

2 participants