Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure to display updated table name #3867

Closed
seancolsen opened this issue Sep 24, 2024 · 2 comments · Fixed by #3879 or #3909
Closed

Intermittent failure to display updated table name #3867

seancolsen opened this issue Sep 24, 2024 · 2 comments · Fixed by #3879 or #3909
Labels
ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

I'm observing a tricky bug when editing a table name via the table inspector. The name is consistently updated in PostgreSQL. But in the UI sometimes new name is updated and sometimes not. I can't seem to identify any correlation between failure and specific reproduction steps. It's also difficult because it doesn't seem to be perfectly random either. For example, I had it succeed 25 times in a row. Then refreshed the page and had it fail 25 times in a row. I've also seen it succeed on the first try and fail on the second. And I've seen it fail on the first try too. My hunch is that there's some sort of race condition in the front end code.

One more clue: I've noticed that sometimes the entire table refreshes after I update its name — as in, the records reload too. And I think it's those times when the renaming succeeds. I'm not positive about this though.

@seancolsen seancolsen added ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue type: bug work: frontend Related to frontend code in the mathesar_ui directory labels Sep 24, 2024
@seancolsen seancolsen added this to the v0.2.0-testing.1 milestone Sep 24, 2024
@seancolsen seancolsen self-assigned this Sep 25, 2024
@pavish
Copy link
Member

pavish commented Oct 1, 2024

I'm re-opening this bug as I'm facing it while performing QA. Here are the latest reproduction steps:

  • Create a table from scratch. It's automatically named Table {n}
  • Rename to ABC.
  • Notice the request succeeds, but the name still displaying as Table {n}

@pavish pavish reopened this Oct 1, 2024
@seancolsen
Copy link
Contributor Author

Ugh. Confirmed. Renaming Table 1 to XYZ also reproduces the bug, so it seems like it's not related to sorting this time around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation regression restricted: maintainers Only maintainers can resolve this issue work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
2 participants