Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Front end can't match groups with records #3742

Closed
seancolsen opened this issue Aug 7, 2024 · 0 comments · Fixed by #3751
Closed

Front end can't match groups with records #3742

seancolsen opened this issue Aug 7, 2024 · 0 comments · Fixed by #3751
Assignees
Labels
ready Ready for implementation work: backend Related to Python, Django, and simple SQL

Comments

@seancolsen
Copy link
Contributor

seancolsen commented Aug 7, 2024

Previously, when grouping records using the REST API, each group object returned had a result_indices field. The front end relied on this field to match groups up with their corresponding result records.

The RPC-based records grouping added in #3721 doesn't seem to provide any way for the front end to match groups to their records.

To minimize implementation time, ideally, we'd use the same structure — a result_indices (array of numbers) within each group object.

I can see that the new RPC API does provide a results_eq, but that doesn't fully allow the front end to match groups with records. For example if I'm grouping an email column by email domain, then results_eq will show only the domain, and the front end won't be able to know what the domain is for the emails within each record.

@seancolsen seancolsen added ready Ready for implementation type: bug work: backend Related to Python, Django, and simple SQL labels Aug 7, 2024
@seancolsen seancolsen added this to the Beta milestone Aug 7, 2024
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation work: backend Related to Python, Django, and simple SQL
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants