Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Create Table From Scratch on schema page #3705

Closed
seancolsen opened this issue Jul 24, 2024 · 0 comments · Fixed by #3819
Closed

Fix Create Table From Scratch on schema page #3705

seancolsen opened this issue Jul 24, 2024 · 0 comments · Fixed by #3819
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory

Comments

@seancolsen
Copy link
Contributor

We need to finish implementing the tables.add RPC API across the stack.

On the schema page, we have a "New Table" dropdown button with a "From Scratch" option. When the user selects this option Mathesar should create a new table, automatically assigning it a name.

Currently, the table is created successfully, but the API does not return information about the name. We should change the API return type from a simple OID value to a JSON object containing the OID and name. We discussed this return type in our 2024-07-23 Technical Beta Planning meeting, and agreed on the above plan.

After the API return value is updated, then the front end needs to make use of the returned name, setting up the table object in the front end store appropriately.

This should be a very small amount of work, both on the back end and the front end.

@seancolsen seancolsen added ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue type: bug work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory labels Jul 24, 2024
@seancolsen seancolsen added this to the Beta milestone Jul 24, 2024
@kgodey kgodey modified the milestones: Beta, Pre-beta test build #1 Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready for implementation restricted: maintainers Only maintainers can resolve this issue work: backend Related to Python, Django, and simple SQL work: frontend Related to frontend code in the mathesar_ui directory
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants