feat(floating-label): add feature targeting for styles #5287
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5287 +/- ##
==========================================
- Coverage 98.52% 98.49% -0.04%
==========================================
Files 163 163
Lines 6313 6313
Branches 865 787 -78
==========================================
- Hits 6220 6218 -2
- Misses 93 95 +2
Continue to review full report at Codecov.
|
| @include mdc-elevation-overlay-opacity(99%, $query: $query); | ||
|
|
||
| // Floating label | ||
| @include mdc-floating-label-core-styles($query: $query); |
There was a problem hiding this comment.
Note that the test:feature-targeting check doesn't seem to be running on the CI because there are failures in the file that's in master. I've added my changes here for completeness.
mmalerba
left a comment
mmalerba
left a comment
There was a problem hiding this comment.
Looks good, can you provide a diff of the emitted CSS before and after to verify no unexpected changes?
|
I've addressed the feedback @mmalerba and I've attached the before/after files. There are a few lines of difference, but they're within the same rule and shouldn't have an effect at runtime. I moved these lines down so that they could fit into an existing feature target. |
crisbeto
force-pushed
the
floating-label-feature-targeting
branch
from
2a96876 to
4be58be
Compare
| } | ||
| // postcss-bem-linter: define floating-label | ||
| .mdc-floating-label { | ||
| @include mdc-typography(subtitle1, $query: $query); |
There was a problem hiding this comment.
nit: Please use $exclude-props to exclude line-height in typography to avoid duplication with below CSS override.
BUILD will throw an error otherwise. :)
/* @alternative */ comment before CSS override would also fix this.
Adds support for feature targeting to the `mdc-floating-label` styles. Relates to material-components#4227.
crisbeto
force-pushed
the
floating-label-feature-targeting
branch
from
4be58be to
59a6189
Compare
5 participants
Adds support for feature targeting to the
mdc-floating-labelstyles.Relates to #4227.