Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chips): Add feature targeting for styles #4693

Merged
merged 2 commits into from
May 13, 2019

Conversation

mmalerba
Copy link
Collaborator

@mmalerba mmalerba commented May 9, 2019

Refs #4227

Note: some styles do move around in the emitted CSS, this is due to splitting the ripple and non-ripple styles. I verified that the chips demo looks the same before and after.

mdc-chips-old.css
mdc-chips-new.css
diff

@codecov-io
Copy link

codecov-io commented May 9, 2019

Codecov Report

Merging #4693 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #4693     +/-   ##
=========================================
+ Coverage   98.96%   99.26%   +0.3%     
=========================================
  Files         129      129             
  Lines        6294     6294             
  Branches      821      821             
=========================================
+ Hits         6229     6248     +19     
+ Misses         64       45     -19     
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-checkbox/component.ts 96.84% <0%> (+1.05%) ⬆️
packages/mdc-tab/component.ts 98.36% <0%> (+3.27%) ⬆️
packages/mdc-base/component.ts 100% <0%> (+3.57%) ⬆️
packages/mdc-ripple/component.ts 100% <0%> (+3.84%) ⬆️
packages/mdc-ripple/util.ts 98% <0%> (+4%) ⬆️
packages/mdc-auto-init/index.ts 100% <0%> (+4.54%) ⬆️
packages/mdc-tabs/tab/component.ts 100% <0%> (+5%) ⬆️
packages/mdc-switch/component.ts 98.24% <0%> (+7.01%) ⬆️
packages/mdc-radio/component.ts 95.74% <0%> (+8.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ddc99d...33912d9. Read the comment docs.

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@abhiomkar abhiomkar merged commit 0fdb889 into material-components:master May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants