Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text-field): Set character counter in setValue #4572

Merged
merged 1 commit into from
Apr 5, 2019

Conversation

patrickrodee
Copy link
Contributor

Set the character counter value in the setValue method

Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@codecov-io
Copy link

codecov-io commented Apr 5, 2019

Codecov Report

Merging #4572 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4572      +/-   ##
==========================================
+ Coverage   99.02%   99.02%   +<.01%     
==========================================
  Files         130      130              
  Lines        6276     6277       +1     
  Branches      820      820              
==========================================
+ Hits         6215     6216       +1     
  Misses         60       60              
  Partials        1        1
Impacted Files Coverage Δ
packages/mdc-textfield/foundation.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975bae2...fe58b66. Read the comment docs.

@mdc-web-bot
Copy link
Collaborator

All 633 screenshot tests passed for commit fe58b66 vs. master! 💯🎉

@patrickrodee patrickrodee merged commit bce2e63 into master Apr 5, 2019
@patrickrodee patrickrodee deleted the feat/textfield/setcharactercounter branch April 5, 2019 22:24
abhiomkar pushed a commit that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants