-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(list): add feature targeting for styles #4303
feat(list): add feature targeting for styles #4303
Conversation
605e933
to
fa3f61f
Compare
@kfranqueiro I've addressed the feedback. Note that I didn't move the styles from |
ece2334
to
78bd5ea
Compare
packages/mdc-list/_mixins.scss
Outdated
@include mdc-typography-overflow-ellipsis($query); | ||
@include mdc-typography-baseline-top($item-primary-text-baseline-height, $query); | ||
@include mdc-typography-baseline-bottom($item-secondary-text-baseline-height, $query); | ||
@include mdc-typography-baseline-top($dense-item-primary-text-baseline-height, $query); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is in the wrong place. This belongs inside .mdc-list--dense & {
below.
78bd5ea
to
02d3ad9
Compare
@kfranqueiro I've addressed the latest set of feedback. |
Sets up feature targeting for
mdc-list
.Here's the before and after output:
before.css.txt
after.css.txt
Some notes: