feat(menu): add feature targeting for styles #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
requested changes
Jan 22, 2019
35 tasks
kfranqueiro
reviewed
Jan 24, 2019
Sets up style feature targeting for `mdc-menu`.
crisbeto
force-pushed
the
menu-style-targeting
branch
from
9eb0ccc
to
34c772d
Compare
|
@kfranqueiro I've rebased and gotten rid of the private mixins. FWIW, I did the individual mixins in the first place so that some consumers could opt out of certain structural styles if they wanted to. |
kfranqueiro
approved these changes
Jan 25, 2019
mmalerba
approved these changes
Jan 25, 2019
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up style feature targeting for
mdc-menu.