fix(drawer): Destroy list in destroy method #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All 349 screenshot tests passed for commit 89ad4f3 vs. |
Codecov Report
@@ Coverage Diff @@
## master #3474 +/- ##
=========================================
Coverage ? 98.42%
=========================================
Files ? 119
Lines ? 5026
Branches ? 617
=========================================
Hits ? 4947
Misses ? 79
Partials ? 0
Continue to review full report at Codecov.
|
|
All 349 screenshot tests passed for commit 2266cf5 vs. |
abhiomkar
approved these changes
Aug 30, 2018
|
All 353 screenshot tests passed for commit 535e2cd vs. |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
(cherry picked from commit 325317c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #3471
List was being instantiated in the
initbut never destroyed.