fix(select): Fix outlined select not changing color without label #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3433 +/- ##
========================================
Coverage ? 98.4%
========================================
Files ? 119
Lines ? 5028
Branches ? 618
========================================
Hits ? 4948
Misses ? 80
Partials ? 0
Continue to review full report at Codecov.
|
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Added: |
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Added: |
kfranqueiro
suggested changes
Aug 30, 2018
| // THE SOFTWARE. | ||
| // | ||
|
|
||
| @import "../../../../packages/mdc-theme/color-palette"; |
| @@ -1,3 +1,19 @@ | |||
| // | |||
There was a problem hiding this comment.
Why did this get added?? This is the old license.
| @@ -99,7 +99,12 @@ class MDCNotchedOutlineFoundation extends MDCFoundation { | |||
| const height = this.adapter_.getHeight(); | |||
| const cornerWidth = radius + 1.2; | |||
| const leadingStrokeLength = Math.abs(12 - cornerWidth); | |||
| const paddedNotchWidth = notchWidth + 8; | |||
|
|
|||
| // If the notchWidth is 0, the label doesn't need padding. | |||
There was a problem hiding this comment.
This comment sounds a bit weird... if the notchWidth is 0, there's no label, right?
kfranqueiro
approved these changes
Aug 30, 2018
|
🤖 Beep boop! Screenshot test report 🚦4 screenshots changed from Details4 Added: |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Sep 25, 2018
…terial-components#3433) (cherry picked from commit a1c0930)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #3230