Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab-bar): Support manual and automatic activation behavior #3303

Merged
merged 7 commits into from
Aug 6, 2018

Conversation

kfranqueiro
Copy link
Contributor

@kfranqueiro kfranqueiro commented Aug 6, 2018

Fixes #3286.

BREAKING CHANGE: Adds focusTabAtIndex and getFocusedTabIndex MDCTabBarAdapter APIs; adds focus MDCTab component API used by MDCTabBar.

@patrickrodee patrickrodee self-assigned this Aug 6, 2018
@mdc-web-bot
Copy link
Collaborator

All 176 screenshot tests passed for commit fcfb30a vs. master! 💯🎉

@mdc-web-bot
Copy link
Collaborator

All 176 screenshot tests passed for commit 67016f8 vs. master! 💯🎉

@codecov-io
Copy link

Codecov Report

Merging #3303 into master will decrease coverage by 0.16%.
The diff coverage is 82.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3303      +/-   ##
==========================================
- Coverage   98.19%   98.03%   -0.17%     
==========================================
  Files         120      120              
  Lines        5151     5184      +33     
  Branches      644      649       +5     
==========================================
+ Hits         5058     5082      +24     
- Misses         93      102       +9
Impacted Files Coverage Δ
packages/mdc-tab-bar/constants.js 100% <ø> (ø) ⬆️
packages/mdc-tab/index.js 96.07% <0%> (-3.93%) ⬇️
packages/mdc-tab-bar/foundation.js 100% <100%> (ø) ⬆️
packages/mdc-tab-bar/index.js 88.88% <30%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9000000...67016f8. Read the comment docs.

@kfranqueiro kfranqueiro merged commit 7182fa1 into master Aug 6, 2018
@kfranqueiro kfranqueiro deleted the feat/tab-activation-behaviors branch August 6, 2018 17:42
@jamesmfriedman jamesmfriedman mentioned this pull request Aug 23, 2018
48 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants