Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): Update adapter to check for focus before calling #2880

Merged
merged 2 commits into from
Jun 5, 2018
Merged

fix(menu): Update adapter to check for focus before calling #2880

merged 2 commits into from
Jun 5, 2018

Conversation

williamernest
Copy link
Contributor

No description provided.

@williamernest williamernest requested a review from moog16 June 4, 2018 23:29
@codecov-io
Copy link

codecov-io commented Jun 4, 2018 •
edited
Loading

Codecov Report

Merging #2880 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2880   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          98       98           
  Lines        4184     4184           
  Branches      532      532           
=======================================
  Hits         4117     4117           
  Misses         67       67
Impacted Files Coverage Δ
packages/mdc-menu/index.js 93.9% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fac7fe...8e0d4ad. Read the comment docs.

moog16
moog16 approved these changes Jun 5, 2018
View reviewed changes
Copy link
Contributor

@moog16 moog16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamernest williamernest merged commit 1548230 into master Jun 5, 2018
@williamernest williamernest deleted the fix/menu/removed-element-no-focus branch June 5, 2018 16:28
williamernest added a commit that referenced this pull request Jun 5, 2018
@williamernest
fix(menu): Update adapter to check for focus before calling (#2880)
367994c
kfranqueiro pushed a commit that referenced this pull request Jun 19, 2018
@williamernest
fix(menu): Update adapter to check for focus before calling (#2880)
84fcc08 
(cherry picked from commit 1548230)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moog16 moog16 moog16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@williamernest @codecov-io @moog16