fix(text-field): Made handleValidationAttributeMutation method public. #2779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moog16
approved these changes
May 21, 2018
packages/mdc-textfield/README.md
Outdated
| @@ -299,6 +299,7 @@ Method Signature | Description | |||
| `isRequired() => boolean` | Returns whether the input is required. | |||
| `setRequired(isRequired: boolean)` | Sets whether the input is required. | |||
| `handleTextFieldInteraction(evt: Event) => void` | Handles click and keydown events originating from inside the Text Field component. | |||
| `handleValidationAttributeMutation(mutationsList: {Array<MutationRecord>}) => void` | Handles validation attribute changes. | |||
There was a problem hiding this comment.
As per an offline conversation, this type should actually non-nullable:
handleValidationAttributeMutation(mutationsList: !Array<MutationRecord>)
|
Updated README & Foundation. |
Codecov Report
@@ Coverage Diff @@
## master #2779 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 98 98
Lines 4231 4231
Branches 538 538
=======================================
Hits 4167 4167
Misses 64 64
Continue to review full report at Codecov.
|
kfranqueiro
deleted the
fix_textfield_handleValidationAttributeMutation_issue2716
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2716