Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dialog): higher '.mdc-dialog__action' specificity #2776

Merged

Conversation

hvolschenk
Copy link
Contributor

Closes #2243

@hvolschenk
Copy link
Contributor Author

I don't quite get why this test isn't running: https://travis-ci.org/material-components/material-components-web/jobs/381379433

It doesn't have anything to do with the changes I made here. I also don't get a retry option on the build, don't really want to push up something else to retry it. 😕

@patrickrodee patrickrodee self-assigned this May 24, 2018
Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Always happy to get contributions :) I have a small change I'd like before I'll merge this.

@@ -122,7 +122,8 @@
}
}

.mdc-dialog__action {
.mdc-dialog__action,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can safely remove this line and the change will work as intended.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot
Copy link

CLAs look good, thanks!

@hvolschenk
Copy link
Contributor Author

Man, again: https://travis-ci.org/material-components/material-components-web/jobs/383029803

ERROR [launcher]: Cannot start Chrome

Anything I can do from my side to spur 'ol Travis along?

@kfranqueiro
Copy link
Contributor

Don't worry about the Travis failure; it's presently unavoidable because the unit tests run through Sauce Labs and use keys configured within Travis, which aren't exposed to forks.

Copy link
Contributor

@patrickrodee patrickrodee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@patrickrodee patrickrodee merged commit 6066795 into material-components:master May 24, 2018
@hvolschenk hvolschenk deleted the fix/dialog-action-button branch May 24, 2018 20:01
trimox added a commit to trimox/angular-mdc-web that referenced this pull request Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants