-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dialog): higher '.mdc-dialog__action' specificity #2776
fix(dialog): higher '.mdc-dialog__action' specificity #2776
Conversation
I don't quite get why this test isn't running: https://travis-ci.org/material-components/material-components-web/jobs/381379433 It doesn't have anything to do with the changes I made here. I also don't get a retry option on the build, don't really want to push up something else to retry it. 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Always happy to get contributions :) I have a small change I'd like before I'll merge this.
packages/mdc-dialog/mdc-dialog.scss
Outdated
@@ -122,7 +122,8 @@ | |||
} | |||
} | |||
|
|||
.mdc-dialog__action { | |||
.mdc-dialog__action, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can safely remove this line and the change will work as intended.
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
afbd2ca
to
93a2443
Compare
CLAs look good, thanks! |
Man, again: https://travis-ci.org/material-components/material-components-web/jobs/383029803
Anything I can do from my side to spur 'ol Travis along? |
Don't worry about the Travis failure; it's presently unavoidable because the unit tests run through Sauce Labs and use keys configured within Travis, which aren't exposed to forks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixed upstream as part of v0.36.0-0 material-components/material-components-web#2776
Closes #2243