fix(checkbox): added aria-checked=mixed to indeterminate state #2389
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2389 +/- ##
==========================================
+ Coverage 98.85% 98.86% +<.01%
==========================================
Files 100 100
Lines 4118 4123 +5
Branches 527 528 +1
==========================================
+ Hits 4071 4076 +5
Misses 47 47
Continue to review full report at Codecov.
|
packages/mdc-checkbox/foundation.js
Outdated
| @@ -203,6 +211,10 @@ class MDCCheckboxFoundation extends MDCFoundation { | |||
| return; | |||
| } | |||
|
|
|||
| // Remove aria-checked (needed for initial inditerminate state) - screen | |||
| // readers will pick the right state from input. | |||
| this.adapter_.removeNativeControlAttr(strings.ARIA_CHECKED_ATTR); | |||
There was a problem hiding this comment.
Is this a possible race condition between when the property change callback gets called and when the attribute gets added?
If so, the attr settter could be moved inside this (transitionCheckState_) method with a check made to newState to determine whether to add or remove.
There was a problem hiding this comment.
Make sure to add the breaking change notes to the footer of the commit message: https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#footer
LGTM!
BREAKING CHANGE: Adds setNativeControlAttr and removeNativeControlAttr adapter APIs.
No description provided.