Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): Avoid using & within @at-root context #2238

Merged
merged 1 commit into from
Feb 12, 2018

Conversation

kfranqueiro
Copy link
Contributor

Fixes #2213.

Compiles successfully with the Sass gem. Has no effect on output CSS via node-sass.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever! LGTM!

@acdvorak acdvorak self-assigned this Feb 12, 2018
@codecov-io
Copy link

Codecov Report

Merging #2238 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2238   +/-   ##
=======================================
  Coverage   99.13%   99.13%           
=======================================
  Files          90       90           
  Lines        3830     3830           
  Branches      496      496           
=======================================
  Hits         3797     3797           
  Misses         33       33

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b57226a...e1654c8. Read the comment docs.

@kfranqueiro kfranqueiro merged commit 665cf12 into master Feb 12, 2018
@kfranqueiro kfranqueiro deleted the fix/checkbox-at-root branch February 12, 2018 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants