chore(textfield): review updates

Author: asyncliz

packages/mdc-textfield/_mixins.scss

@@ -839,13 +839,13 @@
 
 @mixin mdc-text-field-placeholder-color_($color) {
   .mdc-text-field__input::placeholder {
-    color: $color;
+    @include mdc-theme-prop(color, $color);
   }
 
   // Override the placeholder styles in IE with important rule to improve specificity.
   // stylelint-disable-next-line selector-no-vendor-prefix
   .mdc-text-field__input:-ms-input-placeholder {
-    color: $color !important;
+    @include mdc-theme-prop(color, $color, $important: true);
   }
 }
 

test/screenshot/golden.json

@@ -1808,19 +1808,11 @@
     }
   },
   "spec/mdc-textfield/mixins/disabled-2.html": {
-    "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/allanchen/2019/11/06/23_03_42_080/spec/mdc-textfield/mixins/disabled-2.html?utm_source=golden_json",
+    "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/lizmitchell/2019/12/18/21_25_01_625/spec/mdc-textfield/mixins/disabled-2.html?utm_source=golden_json",
     "screenshots": {
-      "desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/allanchen/2019/11/06/23_03_42_080/spec/mdc-textfield/mixins/disabled-2.html.windows_chrome_77.png",
-      "desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/allanchen/2019/11/06/23_03_42_080/spec/mdc-textfield/mixins/disabled-2.html.windows_firefox_69.png",
-      "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/allanchen/2019/11/06/23_03_42_080/spec/mdc-textfield/mixins/disabled-2.html.windows_ie_11.png"
-    }
-  },
-  "spec/mdc-textfield/mixins/disabled-3.html": {
-    "public_url": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/12/18/18_58_50_809/spec/mdc-textfield/mixins/disabled-3.html?utm_source=golden_json",
-    "screenshots": {
-      "desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/12/18/18_58_50_809/spec/mdc-textfield/mixins/disabled-3.html.windows_chrome_77.png",
-      "desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/12/18/18_58_50_809/spec/mdc-textfield/mixins/disabled-3.html.windows_firefox_69.png",
-      "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/travis/2019/12/18/18_58_50_809/spec/mdc-textfield/mixins/disabled-3.html.windows_ie_11.png"
+      "desktop_windows_chrome@77": "https://storage.googleapis.com/mdc-web-screenshot-tests/lizmitchell/2019/12/18/21_25_01_625/spec/mdc-textfield/mixins/disabled-2.html.windows_chrome_77.png",
+      "desktop_windows_firefox@69": "https://storage.googleapis.com/mdc-web-screenshot-tests/lizmitchell/2019/12/18/21_25_01_625/spec/mdc-textfield/mixins/disabled-2.html.windows_firefox_69.png",
+      "desktop_windows_ie@11": "https://storage.googleapis.com/mdc-web-screenshot-tests/lizmitchell/2019/12/18/21_25_01_625/spec/mdc-textfield/mixins/disabled-2.html.windows_ie_11.png"
     }
   },
   "spec/mdc-textfield/mixins/outline-shape-radius.html": {

test/screenshot/spec/mdc-textfield/mixins/disabled-2.html

@@ -185,6 +185,31 @@
 
       </div>
 
+      <div class="test-layout">
+
+        <div class="test-cell test-cell--light test-cell--textfield-small">
+          <div class="mdc-text-field mdc-text-field--no-label mdc-text-field--disabled custom-disabled-colors-text-field--placeholder-color">
+            <!-- htmllint-disable -->
+            <input type="text" class="mdc-text-field__input test-text-field__input" aria-label="Label" disabled placeholder="Placeholder text">
+            <!-- htmllint-enable -->
+            <div class="mdc-line-ripple"></div>
+          </div>
+        </div>
+
+        <div class="test-cell test-cell--light test-cell--textfield-small">
+          <div class="mdc-text-field mdc-text-field--outlined mdc-text-field--no-label mdc-text-field--disabled custom-disabled-colors-text-field--placeholder-color">
+            <!-- htmllint-disable -->
+            <input type="text" class="mdc-text-field__input test-text-field__input" aria-label="Label" disabled placeholder="Placeholder text">
+            <!-- htmllint-enable -->
+            <div class="mdc-notched-outline">
+              <div class="mdc-notched-outline__leading"></div>
+              <div class="mdc-notched-outline__trailing"></div>
+            </div>
+          </div>
+        </div>
+
+      </div>
+
       <div class="test-layout">
 
         <div class="test-cell test-cell--light test-cell--textarea">