|
| 1 | +# Rotation |
| 2 | + |
| 3 | +[TOC] |
| 4 | + |
| 5 | +This page outlines responsibilities for the oncall rotation and issue triaging |
| 6 | +of MDC Web. |
| 7 | + |
| 8 | +## Before you start |
| 9 | + |
| 10 | +* Complete MDC Web [onboarding](http://go/mdc-web-onboard) process. |
| 11 | +* Join |
| 12 | + [MDC Web rotation](https://rotations.corp.google.com/rotation/5708184800985088) |
| 13 | + calendar. |
| 14 | +* Add "Material Web Triage" meeting to your calendar. |
| 15 | +* Go to |
| 16 | + [MDC Web ZenHub Dashboard](https://goto.google.com/mdc-web-triage-bugs) to |
| 17 | + see Untriaged issues. (Sort Untriaged pipeline |
| 18 | + [by New](https://screenshot.googleplex.com/r90Yeco4ebw.png)) |
| 19 | +* Set up notifications of your GitHub profile to receive emails for any |
| 20 | + activity on MDC Web |
| 21 | + [GitHub repository](https://github.com/material-components/material-components-web) |
| 22 | + when you're on-call. |
| 23 | + |
| 24 | +## Rotation |
| 25 | + |
| 26 | +Responsibilities of rotation on-call include: |
| 27 | + |
| 28 | +* Responding to GitHub |
| 29 | + [issues](https://github.com/material-components/material-components-web/issues) |
| 30 | +* Code reviewing external / internal GitHub |
| 31 | + [pull requests](https://github.com/material-components/material-components-web/pulls) |
| 32 | + (PR's) |
| 33 | +* Importing external GitHub PR's when they're ready to merge. See |
| 34 | + go/mdc-web-g3sync |
| 35 | + |
| 36 | +### Issues |
| 37 | + |
| 38 | +Being on-call does not mean you have be the one to actually fix issues, we |
| 39 | +simply triage. Issues may fall in one of the following categories. |
| 40 | + |
| 41 | +#### Feature Requests |
| 42 | + |
| 43 | +First, check if this request is in the [spec](https://material.io/guidelines). |
| 44 | +If you're not sure, reach out to Material System UX on-call - go/system-team or |
| 45 | +open a thread in Material System chat room: |
| 46 | + |
| 47 | +* If it is not in spec, respond on the PR that we do not accept feature |
| 48 | + requests for components that are not in our spec, and close it. |
| 49 | +* If it is in the spec, discuss in triage meeting and move it to backlog. |
| 50 | + |
| 51 | +#### Bugs |
| 52 | + |
| 53 | +When a bug is reported, first ensure it has clear reproducible steps with |
| 54 | +sufficient information. If not, point them to our |
| 55 | +[bug template](https://github.com/material-components/material-components-web/issues/new?assignees=&labels=bug&template=--bug-report.md&title=%5BComponentName%5D+title) |
| 56 | +and ask for more information. |
| 57 | + |
| 58 | +If you're able to reproduce the bug and it is a legitimate bug in MDC Web, |
| 59 | +respond that you were able to reproduce the bug and move it to backlog. If |
| 60 | +you're not able to reproduce the bug, ask for more information. |
| 61 | + |
| 62 | +If the bug is small, encourage them to open a PR before moving it to backlog. |
| 63 | + |
| 64 | +#### Other issues |
| 65 | + |
| 66 | +There are other issues outside of FR's or bugs, although try not to spend too |
| 67 | +much time investigating issues that are out of scope for MDC Web. Issues can be |
| 68 | +closed if you think they are out of scope. |
| 69 | + |
| 70 | +* There are a few **installation problems** that we can help with, such as, |
| 71 | + installing MDC Web components and usage. However, it's best if the answer to |
| 72 | + this question is a link to documentation. If it is out of scope, tell the |
| 73 | + reporter we do not have the expertise to help them with this question, |
| 74 | + suggest they ask on Stack Overflow for better results, and close the issue. |
| 75 | +* Respond to any **general questions** and see if we're missing any |
| 76 | + documentation. Encourage them to post on Stack Overflow instead and close |
| 77 | + it. |
| 78 | + |
| 79 | +### Pull requests |
| 80 | + |
| 81 | +Any external contributions received via GitHub |
| 82 | +[pull requests](https://github.com/material-components/material-components-web/pulls) |
| 83 | +on MDC Web repo needs to be reviewed or needs attention. Googlers should always |
| 84 | +send CLs. |
| 85 | + |
| 86 | +Follow these steps to address any external contributions: |
| 87 | + |
| 88 | +* When you're reviewing code, identify if PR contains any breaking change. If |
| 89 | + it is a huge breaking change, ask the author to revert any breaking changes |
| 90 | + or close the PR. |
| 91 | +* Follow go/mdc-web-g3sync to import a PR into google3/. (You may need to add |
| 92 | + additional changes in google3, such as updating BUILD rules.) |
| 93 | +* PR can't be merged without importing it into google3. |
| 94 | +* Always run a TGP (go/tgp) on the imported CL. |
| 95 | + |
| 96 | +## Triage meeting |
| 97 | + |
| 98 | +Triage meeting happens every Friday. If you're on-call that week, attendance is |
| 99 | +mandatory. |
| 100 | + |
| 101 | +On-call primary drives this meeting. Triaging involves the following steps: |
| 102 | + |
| 103 | +* Open [MDC Web ZenHub Dashboard](https://goto.google.com/mdc-web-triage-bugs) |
| 104 | + and present it to everyone. |
| 105 | +* Sort "Untriaged" pipeline by "New" (any new issues that are opened |
| 106 | + automatically appear here). |
| 107 | +* Go through issues that you think that needs team discussion. |
| 108 | + |
| 109 | +In most of the cases, the oncall should have already gone through all new issues |
| 110 | +and have a good understanding of the issue. This makes the triage meeting |
| 111 | +smoother to discuss. |
0 commit comments