chore(textfield): separate position mixins for leading/trailing icons

Author: asyncliz

packages/mdc-textfield/_mixins.scss

@@ -622,10 +622,7 @@
 // Icons
 
 @mixin mdc-text-field-with-leading-icon_ {
-  @include mdc-text-field-icon-horizontal-position_(
-    left,
-    $mdc-text-field-icon-position
-  );
+  @include mdc-text-field-leading-icon-horizontal-position_($mdc-text-field-icon-position);
 
   .mdc-text-field__input {
     @include mdc-rtl-reflexive-property(padding, $mdc-text-field-icon-padding, $mdc-text-field-input-padding);
@@ -637,10 +634,7 @@
 }
 
 @mixin mdc-text-field-dense-with-leading-icon_ {
-  @include mdc-text-field-icon-horizontal-position_(
-    left,
-    $mdc-text-field-dense-icon-position
-  );
+  @include mdc-text-field-leading-icon-horizontal-position_($mdc-text-field-dense-icon-position);
 
   .mdc-text-field__input {
     @include mdc-rtl-reflexive-property(padding, $mdc-text-field-dense-icon-padding, $mdc-text-field-input-padding);
@@ -652,10 +646,7 @@
 }
 
 @mixin mdc-text-field-outlined-with-leading-icon_ {
-  @include mdc-text-field-icon-horizontal-position_(
-    left,
-    $mdc-text-field-icon-position
-  );
+  @include mdc-text-field-leading-icon-horizontal-position_($mdc-text-field-icon-position);
   @include mdc-notched-outline-floating-label-float-position-absolute($mdc-text-field-outlined-label-position-y, 32px);
   @include mdc-floating-label-shake-animation(text-field-outlined-leading-icon);
 
@@ -686,53 +677,34 @@
 }
 
 @mixin mdc-text-field-with-trailing-icon_ {
-  @include mdc-text-field-icon-horizontal-position_(
-    right,
-    $mdc-text-field-trailing-icon-position
-  );
+  @include mdc-text-field-trailing-icon-horizontal-position_($mdc-text-field-trailing-icon-position);
 
   .mdc-text-field__input {
     @include mdc-rtl-reflexive-property(padding, $mdc-text-field-input-padding, $mdc-text-field-icon-padding);
   }
 
   // Outlined uses 16px for text alignment when using a trailing icon.
   &.mdc-text-field--outlined {
-    @include mdc-text-field-icon-horizontal-position_(
-      right,
-      $mdc-text-field-icon-position
-    );
+    @include mdc-text-field-trailing-icon-horizontal-position_($mdc-text-field-icon-position);
   }
 }
 
 @mixin mdc-text-field-dense-with-trailing-icon_ {
-  @include mdc-text-field-icon-horizontal-position_(
-    right,
-    $mdc-text-field-dense-icon-position
-  );
+  @include mdc-text-field-trailing-icon-horizontal-position_($mdc-text-field-dense-icon-position);
 
   .mdc-text-field__input {
     @include mdc-rtl-reflexive-property(padding, $mdc-text-field-input-padding, $mdc-text-field-dense-icon-padding);
   }
 }
 
 @mixin mdc-text-field-with-both-icons_ {
-  @include mdc-text-field-icon-horizontal-position-two-icons_(
-    $mdc-text-field-icon-position,
-    $mdc-text-field-trailing-icon-position
-  );
-
   .mdc-text-field__input {
     padding-right: $mdc-text-field-icon-padding;
     padding-left: $mdc-text-field-icon-padding;
   }
 }
 
 @mixin mdc-text-field-dense-with-both-icons_ {
-  @include mdc-text-field-icon-horizontal-position-two-icons_(
-    $mdc-text-field-dense-icon-position,
-    $mdc-text-field-dense-icon-position
-  );
-
   .mdc-text-field__input {
     padding-right: $mdc-text-field-dense-icon-padding;
     padding-left: $mdc-text-field-dense-icon-padding;

packages/mdc-textfield/icon/_mixins.scss

@@ -59,25 +59,15 @@
 
 // Private mixins
 
-@mixin mdc-text-field-icon-horizontal-position_($position-property, $position) {
-  @if ($position-property == left) {
-    .mdc-text-field__icon--leading {
-      @include mdc-rtl-reflexive-position($position-property, $position);
-    }
-  } @else {
-    .mdc-text-field__icon--trailing {
-      @include mdc-rtl-reflexive-position($position-property, $position);
-    }
-  }
-}
-
-@mixin mdc-text-field-icon-horizontal-position-two-icons_($position-left, $position-right) {
+@mixin mdc-text-field-leading-icon-horizontal-position_($position) {
   .mdc-text-field__icon--leading {
-    @include mdc-rtl-reflexive(left, $position-left, right, auto);
+    @include mdc-rtl-reflexive-position(left, $position);
   }
+}
 
+@mixin mdc-text-field-trailing-icon-horizontal-position_($position) {
   .mdc-text-field__icon--trailing {
-    @include mdc-rtl-reflexive(right, $position-right, left, auto);
+    @include mdc-rtl-reflexive-position(right, $position);
   }
 }