it doesn't work here.

anyway, unzip only supports "read only", so, I don't like it, it must work maybe with a gsettings key

(EDIT: it works in read/write mode, I don't know how it works, but it works)

and, we have the ability to use unar to open zip files since c587ae1 .

I noticed using unar fixes #278 , and probably more issues.

@sc0w that's a good point, but I think this should work automatically. For a user to have to change gsettings to open a file is not good UX, maybe we can prioritize unar instead of unzip? Why do we need the gsettings instead of just making it automatic?

@vkareh because unar open zip files with "read only" mode.

I noticed this PR fixes #201 but it doesn't fix the name of files in the other issues you mentioned in #279 (comment)

and zip files are opened locally in "read / write" mode, this is a good point.

unzip only supports "read only"

and

unar open zip files with "read only" mode

and

zip files are opened locally in "read / write" mode

Those three statements confuse me a bit, which ones open in read-only and which ones open in read/write mode?

This fixes the file name issues for me. I wonder what's different between our configurations. I'll play around with settings to see if I find anything.

Those three statements confuse me a bit, which ones open in read-only and which ones open in read/write mode?

All are opened in read/write mode, I was wrong, I edited that before. I don't know how it works, but it works.

now I agree with this PR because fixes the issue of password, but I don't understand why the names of files works for you, and it doesn't work here.

awaiting the tests of others...

ok, seeing the code I noticed it uses unzip to show the files, and the command zip to compress

Thanks for the clarification :)

I still haven't found why it may not work for you for file names... I'll keep trying different things on my side to reproduce the issue

@sc0w, I've edited the list of issues this will fix. All other issues are already closed, and the only other one (#102) seems to display the wrong character set with either p7z, unar, or unzip. So I removed it from this list. We're only left with #5 (feature request to prioritize unzip) and #201 (password encoding).

I noticed one problem with this PR with .zip files compressed with password by 7z

how to reproduce:

without this PR, select some files in caja, right click, compress in zip, other options, set password, and create. (it is created by 7z).

install this PR, and try to open, it doesn't work, seems it isn't supported by unzip.

file sample, the pass is 123:

pass123.zip

skipping: engrampa_1.20.2-1_amd64.buildinfo need PK compat. v5.1 (can do v4.6)

What happens with that PR?
Is someone working on it or can we close it?

@vkareh @sc0w
Any news?

There hasn't been consensus in a year. Closing for now.