Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native HTML modal dialog support is buggy #491

Open
fstrr opened this issue Oct 26, 2022 · 1 comment
Open

native HTML modal dialog support is buggy #491

fstrr opened this issue Oct 26, 2022 · 1 comment
Assignees
Labels

Comments

@fstrr
Copy link

fstrr commented Oct 26, 2022

When a native HTML modal dialog element is open, browsers hide the content on the underlying page from assistive technology. For example: VoiceOver, NVDA, and JAWS will only list content (landmarks, headings, etc.) in the open modal dialog.

The current version of the extension doesn't pick up on the modal dialog being open or closed by the user. For example: if I have a page with a main element in it, and a modal dialog with a main element in it, when the dialog is opened and closed, the extension doesn't update to list the current main landmark.

Here's a test case in codepen. Note: you'll have to put the page into "debug mode" for the test case to work correctly.

@matatk
Copy link
Owner

matatk commented Nov 11, 2022

Thank you @fstrr for your clear bug report and test case. I'd planned to reply only when I had a fix, but I have still not been able to investigate, beyond confirming the issue. I suspect it's happening because showing the modal is not triggering a mutation event, but if that's the case I'm really not sure how to detect the dialog. I do hope to look into it more fully soon. For now, thanks again for the great test case.

@matatk matatk added the bug label Nov 11, 2022
@matatk matatk self-assigned this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants