Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

major version number should be bumped; renaming flex.scss was a breaking change #31

Closed
jedwards1211 opened this issue May 5, 2016 · 10 comments

Comments

@jedwards1211
Copy link

it looks like flex.scss was renamed to _flexbox.scss. This has broken our projects that are using webpack with sass-loader and doing

@import ~sass-flex-mixin/flex

The project-breaking happened spontaneously on our build server since version 1.0.2 is considered compatible with ^1.0.0.

Thanks for these awesome mixins!

@jedwards1211
Copy link
Author

jedwards1211 commented May 5, 2016

Assuming that only Webpack users will be doing require('sass-flex-mixin') (or indirectly via @import ~sass-flex-mixin using sass-loader, it would be best if your package.json contains:

"main": "_flexbox.scss"

@fieg
Copy link

fieg commented May 9, 2016

Yes, this was indeed a breaking change in a patch update. Broke our project too :(

@mastastealth
Copy link
Owner

Dang it. I knew something like this would have happened. :( My bad. Will look into it.

@fieg
Copy link

fieg commented May 10, 2016

I think a fix would be something like this:

  1. revert the rename
  2. tag a new patch version
  3. reapply the rename
  4. tag a new major version

@roelentless
Copy link

+1 this broke our build!

@verlok
Copy link

verlok commented May 11, 2016

We solved this removing the usage of flex mixins and instead using plain CSS + adding postcss / autoprefixer in our build flow.

@jedwards1211
Copy link
Author

@verlok it's not like this issue was difficult to fix, one just had to find and replace references to the file...switching to completely different tools isn't really a "solution", it's a non sequitur.

@verlok
Copy link

verlok commented May 11, 2016

We didn't do that only for solving this, but to use the real CSS instructions in general (not only for flex), which are also supported by code-hint in editors. Also, we can decide to stop supporting IE10 tomorrow and update the code only by changing a configuration.

@jedwards1211
Copy link
Author

Wow, not having to support IE10 sounds nice!

@mastastealth
Copy link
Owner

mastastealth commented May 12, 2016

Per @fieg's suggestion I reverted the rename, bumped version, and republished release. Hopefully that fixes everyone's issues (or avoids future issues). Sorry for that, first repo with actual users and bower/npm stuff so you'll forgive me as I learn the ins and outs of maintenance. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants