Temporary set a version of rust #2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you see this commit in a month and it's not already revert, try to revert it quick!
AureliaDolo
approved these changes
Jan 12, 2022
see #2142 |
|
bors merge |
bors bot
added a commit
that referenced
this pull request
Jan 12, 2022
2141: Temporary set a version of rust r=AureliaDolo a=adrien-zinger Set a version temporary, waiting for a nightly release compatible. Version rustc: 1.59.0 > If you see this commit in a month and it's not already revert, try to revert it quick! Co-authored-by: Adrien Zinger <[email protected]>
|
Build failed: |
|
@damip and mcos is failling again with test_roll_block_creation |
|
let's also disable the problematic test in this PR and open an issue for corrrecting it |
damip
requested changes
Jan 13, 2022
|
Could we ensure that this PR will be reverted soon? Could we link here the |
|
see #2142 for follow up |
AurelienFT
added a commit
to AurelienFT/massa
that referenced
this pull request
Jan 15, 2022
…fixed : rust-lang/rust#92781 Partially resolve massalabs#2142
bors bot
added a commit
that referenced
this pull request
Jan 18, 2022
2155: Revert the version of Rust fixed r=damip a=AurelienFT Revert #2141 because the bug on the nightly compiler has been fixed : rust-lang/rust#92781 This will partially resolve #2142. I don't know which version should be documented for the episode so I didn't add it to this PR. Co-authored-by: AurelienFT <[email protected]> Co-authored-by: AurelienFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set a version temporary, waiting for a nightly release compatible.
Version rustc: 1.59.0