Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #2141 after bugfix (and update wiki) #2142

Closed
AureliaDolo opened this issue Jan 12, 2022 · 3 comments · Fixed by #2155
Closed

Revert #2141 after bugfix (and update wiki) #2142

AureliaDolo opened this issue Jan 12, 2022 · 3 comments · Fixed by #2155
Milestone
TEST.7.0

Comments

@AureliaDolo
Copy link
Contributor

Revert #2141 after rust-lang/rust#92781 is merged and the compiler bug fixed

And don't forget to update the default nightly locally too.
And maybe we should add a line about that in the doc, as currently testnet users pinned a specific nightly as default.
@AureliaDolo AureliaDolo mentioned this issue Jan 12, 2022
Merged
AurelienFT added a commit to AurelienFT/massa that referenced this issue Jan 15, 2022
@AurelienFT
Revert the version of Rust fixed.
57f762d 
Revert #92781 because the bug on the nightly compiler has been fixed : rust-lang/rust#92781

Closes  massalabs#2142
@AurelienFT AurelienFT mentioned this issue Jan 15, 2022
Merged
@damip damip added this to the TEST.7.0 milestone Jan 17, 2022
@damip
Copy link
Member

damip commented Jan 18, 2022

Everything corrected. Just need to notify users

bors bot added a commit that referenced this issue Jan 18, 2022
@bors @AurelienFT
Merge #2155
b90a073 
2155: Revert the version of Rust fixed r=damip a=AurelienFT

Revert #2141  because the bug on the nightly compiler has been fixed : rust-lang/rust#92781

This will partially resolve  #2142.

I don't know which version should be documented for the episode so I didn't add it to this PR.

Co-authored-by: AurelienFT <[email protected]>
Co-authored-by: AurelienFT <[email protected]>
@bors bors bot closed this as completed in 3a80485 Jan 18, 2022
@AureliaDolo
Copy link
Contributor Author

I was thinking about adding a line to make sure everyone uses the latest nightly as default I order to avoid that people that were here during the bug keep using the pinned version @Noxhaa

@Noxhaa
Copy link
Contributor

Noxhaa commented Jan 18, 2022

I will just need to add rustup default nightly on the update tutorial. I'll do so just before the release of 6.6. Please keep me posted when you know when this will be.

@AureliaDolo AureliaDolo mentioned this issue Jan 19, 2022
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
TEST.7.0
Development

Successfully merging a pull request may close this issue.

Revert the version of Rust fixed AurelienFT/massa
3 participants
@damip @AureliaDolo @Noxhaa