Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: Option to NOT to create c.html in home directory on article previewing #1506

Closed
r23vme opened this issue Sep 25, 2024 · 4 comments
Closed
Assignees
Labels
Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Milestone

Comments

@r23vme
Copy link

r23vme commented Sep 25, 2024

Brief description of the feature request

When checkbox "Article"->"Enable article preview" is checked selecting articles creates "c.html" file containing corresponding preview.

A setting to NOT to create such a file or to create it in user specified location, like /tmp/c.html, would be nice.

@r23vme r23vme added the Type-Enhancement This is request for brand new feature. label Sep 25, 2024
@martinrotter
Copy link
Owner

How do you compile RSS Guard? How did you install RSS Guard?

File "c.html" is there for debugging purposes and is NOT created in Release builds of RSS Guard, it is only created in Debug build.

@martinrotter
Copy link
Owner

Anyway, I removed the code.

aaed843

@martinrotter martinrotter added this to the 4.7.4 milestone Sep 26, 2024
@martinrotter martinrotter added the Status-Fixed Ticket is resolved. label Sep 26, 2024
@r23vme
Copy link
Author

r23vme commented Sep 26, 2024

Thank you!

How do you compile RSS Guard? How did you install RSS Guard?

I install it from standard gentoo repository. Thats the ebuild with gentoo stuff omitted:

...
src_configure() {
	local mycmakeargs=(
		-DBUILD_WITH_QT6=$(usex qt6)
		-DNO_LITE=$(usex webengine)
		-DREVISION_FROM_GIT=OFF
		-DNO_UPDATE_CHECK=ON
		-DENABLE_COMPRESSED_SITEMAP=ON
		-DENABLE_MEDIAPLAYER_QTMULTIMEDIA=$(usex qtmultimedia)
		-DENABLE_MEDIAPLAYER_LIBMPV=$(usex libmpv)
		# recommended
		-DMEDIAPLAYER_FORCE_OPENGL=ON
	)

	cmake_src_configure
}
...

https://gitweb.gentoo.org/repo/gentoo.git/tree/net-news/rssguard/rssguard-4.7.3.ebuild

I probably should have risen the issue with the gentoo repo maintainers, sorry to bother you. Will adding "-DCMAKE_BUILD_TYPE="Release"" to mycmakeargs in the ebuild above eliminate the issue without making you to remove debug code?

@martinrotter
Copy link
Owner

Will adding "-DCMAKE_BUILD_TYPE="Release"" to mycmakeargs in the ebuild above eliminate the issue without making you to remove debug code?

Yes, it will. Moreover I removed the debug line entirely and released 4.7.4 now, so update to 4.7.4 should resolve your problem anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status-Fixed Ticket is resolved. Type-Enhancement This is request for brand new feature.
Projects
None yet
Development

No branches or pull requests

2 participants