Skip to content

Conversation

@martincostello
Copy link
Owner

Disable new CA1873 warning for .NET 10.

Disable new CA1873 warning for .NET 10.
Copilot AI review requested due to automatic review settings July 15, 2025 17:53
@martincostello martincostello added the enhancement New feature or request label Jul 15, 2025
@martincostello martincostello enabled auto-merge (rebase) July 15, 2025 17:53
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Disable the new CA1873 code analysis warning by adding it to the project’s NoWarn list.

  • Added CA1873 to the NoWarn property in SampleApp.csproj
Comments suppressed due to low confidence (1)

tests/SampleApp/SampleApp.csproj:5

  • [nitpick] The PR description refers to .NET 10, but the project targets net9.0—consider updating the TargetFramework to net10.0 if the change is meant for .NET 10.
    <TargetFramework>net9.0</TargetFramework>

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.59%. Comparing base (cff617a) to head (729e9b7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   98.59%   98.59%           
=======================================
  Files          16       16           
  Lines         284      284           
  Branches       37       37           
=======================================
  Hits          280      280           
  Misses          2        2           
  Partials        2        2           
Flag Coverage Δ
linux 98.59% <ø> (ø)
macos 97.88% <ø> (ø)
windows 98.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello merged commit 0529d22 into main Jul 15, 2025
14 checks passed
@martincostello martincostello deleted the disable-CA1873 branch July 15, 2025 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants