Skip to content

Conversation

@martincostello
Copy link
Owner

Add Sentry error reporting.

@martincostello martincostello added enhancement dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Apr 13, 2025
Copilot AI review requested due to automatic review settings April 13, 2025 13:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • Directory.Packages.props: Language not supported
  • src/Website/Website.csproj: Language not supported

@martincostello martincostello enabled auto-merge (squash) April 13, 2025 13:45
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:5001

Device URL
mobile https://localhost:5001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

@codecov
Copy link

codecov bot commented Apr 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (4448529) to head (879fbe5).
Report is 25 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/Website/WebsiteBuilder.cs 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2504      +/-   ##
==========================================
+ Coverage   86.69%   88.21%   +1.52%     
==========================================
  Files          33       31       -2     
  Lines         541      628      +87     
  Branches       67       66       -1     
==========================================
+ Hits          469      554      +85     
- Misses         32       33       +1     
- Partials       40       41       +1     
Flag Coverage Δ
linux 88.21% <0.00%> (+1.52%) ⬆️
macos 88.21% <0.00%> (+1.52%) ⬆️
windows 88.21% <0.00%> (+1.52%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello marked this pull request as draft April 13, 2025 14:19
auto-merge was automatically disabled April 13, 2025 14:19

Pull request was converted to draft

@martincostello
Copy link
Owner Author

@costellobot rebase

Add Sentry error reporting.
Add workaround for Sentry issue.
Install dependencies that Sentry native depends on to fix build.
Add link to Sentry issue.
@martincostello
Copy link
Owner Author

Depends on getsentry/sentry-dotnet#4107 - there are too many native dependencies to copy around to get Sentry native working on a chiseled container, so will just disable it instead.

Update Sentry to the latest release and remove some workarounds.
Looks like the BuildKit change didn't work.
Try latest beta.
Should take effect from the NuGet package.
Sentry Native cannot be disabled via this package as it gets evaluated too early.
Disable to fix native AoT compilation.
Update to the latest release.
@martincostello martincostello marked this pull request as ready for review May 31, 2025 13:02
@martincostello martincostello merged commit ff673bb into main May 31, 2025
14 of 15 checks passed
@martincostello martincostello deleted the add-sentry branch May 31, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement .NET Pull requests that update .NET code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants