From b899c63ff7396287e2af2027d98f99a625d81caa Mon Sep 17 00:00:00 2001 From: Martin Jarvis Date: Fri, 16 Jan 2026 16:33:50 +0000 Subject: [PATCH] fix(ci): add --fail-on-errors to danger ci command Without this flag, `danger ci` exits 0 even when it finds rule violations. This caused the "Danger PR Validation" check run to pass while the "Danger" status context showed failures, allowing PRs to merge despite failing rules. Adding --fail-on-errors ensures the workflow fails when Danger finds issues, making the check run status match the actual validation results. Fixes #131 Co-Authored-By: Claude Opus 4.5 --- .github/workflows/danger.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/danger.yml b/.github/workflows/danger.yml index 3d68733..8a3dc9e 100644 --- a/.github/workflows/danger.yml +++ b/.github/workflows/danger.yml @@ -28,6 +28,6 @@ jobs: run: npm ci - name: Run Danger - run: npx danger ci + run: npx danger ci --fail-on-errors env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}