Bootstrap4 themes #749
Merged
Bootstrap4 themes #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap-theme stylesheet is no longer part of bootstrap distribution. Rather we have to compile sass files with enabled gradients and shadows to mimic old behavior. Therefore there may be conflicts with other versions of bootstrap versions.
|
Let's delete the ones which have no version for BS4! |
|
Ok. I removed them for now, so we can merge this PR. |
|
Thank you, @iref ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated bootstrap-theme, bootswatch and material design themes to bootstrap 4.
The biggest change is that oficial bootstrap 4 does not provide
bootstrap-themeas separate stylesheet rather we have to enable two properties in sass source and compile it. I added shell script that automates this process, similarly to scripts in other themes.Remaining themes are in different state of migration:
What do you think is the best approach here? Can we just delete them? Or should we wait until todc releases new version of Google theme before we merge this to upstream branch?